Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simulator: scale-in and scale out test for store-limit-version=v2 #8220

Merged
merged 7 commits into from
Jun 28, 2024

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented May 28, 2024

What problem does this PR solve?

Issue Number: Ref #8135

renew #7792

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Copy link
Contributor

ti-chi-bot bot commented May 28, 2024

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot requested review from nolouch and rleungx May 28, 2024 06:02
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 28, 2024
tools/pd-simulator/simulator/cases/scale_tikv.go Outdated Show resolved Hide resolved
tools/pd-simulator/simulator/cases/scale_tikv.go Outdated Show resolved Hide resolved
Comment on lines 75 to 81
simCase.Checker = func(regions *core.RegionsInfo, stats []info.StoreStats) bool {
return false
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you wish to prevent the case from being exited?

…imit-v2

Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.44%. Comparing base (4048cba) to head (b2a676e).

Current head b2a676e differs from pull request most recent head 4148657

Please upload reports for the commit 4148657 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8220      +/-   ##
==========================================
+ Coverage   77.10%   77.44%   +0.33%     
==========================================
  Files         470      471       +1     
  Lines       61553    61394     -159     
==========================================
+ Hits        47463    47548      +85     
+ Misses      10506    10297     -209     
+ Partials     3584     3549      -35     
Flag Coverage Δ
unittests 77.44% <75.00%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Comment on lines +497 to +501
cfg := h.GetScheduleConfig()
if version := cfg.StoreLimitVersion; version != storelimit.VersionV1 {
h.rd.JSON(w, http.StatusBadRequest, fmt.Sprintf("current store limit version:%s not support get limit", version))
return
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do SetStoreLimitSceneandGetStoreLimitScene` only need to support v2 as well?

Copy link
Contributor

ti-chi-bot bot commented Jun 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-25 07:48:03.080374086 +0000 UTC m=+705809.565862918: ☑️ agreed by HuSharp.

Copy link
Contributor

ti-chi-bot bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 25, 2024
@lhy1024 lhy1024 added require-LGT1 Indicates that the PR requires an LGTM. and removed needs-1-more-lgtm labels Jun 27, 2024
Signed-off-by: lhy1024 <admin@liudos.us>
@HuSharp HuSharp added the lgtm label Jun 28, 2024
@ti-chi-bot ti-chi-bot bot merged commit e99b3ac into tikv:master Jun 28, 2024
16 of 17 checks passed
@lhy1024 lhy1024 deleted the store-limit-v2 branch June 28, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes lgtm release-note-none require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants